-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
created first version of getShopfloorInformationAspect #235
created first version of getShopfloorInformationAspect #235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check my comments
########################################################################################## | ||
# Copyright (c) 2023 Fraunhofer-Gesellschaft zur Förderung der angewandten Forschung e. V. | ||
# Copyright (c) 2023 Siemens AG | ||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add
// # Copyright (c) 2023 Contributors to the Eclipse Foundation
@@ -0,0 +1,53 @@ | |||
########################################################################################## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unusual to have the datatypes separated in a different model. Should work but modelers are required to load both models into the editor, which might lead to confusion
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> . | ||
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> . | ||
@prefix xsd: <http://www.w3.org/2001/XMLSchema#> . | ||
@prefix : <urn:samm:io.catenax.mp_standard_unsubscribe:1.0.0#> . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
namespace and folder must match, so namespace must be
io.catenax.mp_standard_request
or folder must be
io.catenax.mp_standard_unsubscribe
|
||
:timeUnit a samm:Property ; | ||
samm:preferredName "timeUnit"@en ; | ||
samm:description "specifies the unit in which the time es represented"@en ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start with uppercase
samm:characteristic :TimeUnitEnum ; | ||
samm:exampleValue "Month" . | ||
|
||
:TimeUnitEnum a samm-c:Enumeration ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not using the xsd timestamp as datatype or even consider using the pre-defined Timestamp characteristic and not redefining data structure.
@prefix ext-unsubscribe: <urn:samm:mp_standard_unsubscribe:1.0.0#> . | ||
|
||
:GetShopfloorInformation a samm:Aspect ; | ||
samm:preferredName "GetShopfloorInformation"@en ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should follow normal orthography so no camel case but white spaces
########################################################################################## | ||
# Copyright (c) 2023 Fraunhofer-Gesellschaft zur Förderung der angewandten Forschung e. V. | ||
# Copyright (c) 2023 Siemens AG | ||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also add Eclipse copyright entry
samm:events ( ) . | ||
|
||
:synchronousRequest a samm:Property ; | ||
samm:preferredName "synchronousRequest"@en ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preferred name is used to present the element to the user. So it should follow normal orthography. Usually the name is also a proper noun so write uppercase. Please check all elements, will not mark it again
|
||
:cxHeader a samm:Property ; | ||
samm:preferredName "cxHeader"@en ; | ||
samm:description "header that refers to the request of a customer"@en ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start uppercase in all descriptions
Validation Report for io.catenax.mp_standard_request/1.0.0/GetShopfloorInformation.ttlValidation failed: |
Validation Report for io.catenax.mp_standard_request/1.0.0/DataTypes.ttlValidation failed: |
samm:description "DataType for a synchronous Header"@en ; | ||
samm:dataType :SynchronousHeaderEntity . | ||
|
||
:CXHeaderCharacteristic a samm:Characteristic ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can import the characteristic directly or even the property, if it fits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check my comments
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> . | ||
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> . | ||
@prefix xsd: <http://www.w3.org/2001/XMLSchema#> . | ||
@prefix : <urn:samm:io.catenax.shared.shopfloor_information_types:1.0.0#> . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to reside in its own folder as the namespaces must correspond to the folder structure. Please check
https://github.com/eclipse-tractusx/sldt-semantic-models/tree/main/io.catenax.shared.physical_dimension
as an example
samm:events ( ) . | ||
|
||
:communicationMode a samm:Property ; | ||
samm:preferredName "communication Mode"@en ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uppercase C in communication as the prefered name is usually used as proper noun
please also check all other preferredNames and adjust accordingly
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> . | ||
@prefix xsd: <http://www.w3.org/2001/XMLSchema#> . | ||
@prefix : <urn:samm:io.catenax.shopfloor_information.get_production_forecast:1.0.0#> . | ||
@prefix ext-header: <urn:samm:io.catenax.messaging_header:1.0.0#> . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you plan to use this model
https://github.com/eclipse-tractusx/sldt-semantic-models/pull/227/files
you need to adjust the namespace to
urn:samm:io.catenax.message_header:1.0.0#
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> . | ||
@prefix xsd: <http://www.w3.org/2001/XMLSchema#> . | ||
@prefix : <urn:samm:io.catenax.shared.shopfloor_information_types:1.0.0#> . | ||
@prefix ext-header: <urn:samm:io.catenax.messaging_header:1.0.0#> . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you plan to use this model
https://github.com/eclipse-tractusx/sldt-semantic-models/pull/227/files
you need to adjust the namespace to
urn:samm:io.catenax.message_header:1.0.0#
samm:preferredName "TimeUnitEnum"@en ; | ||
samm:description "Enumerates all possible time units"@en ; | ||
samm:dataType xsd:string ; | ||
samm-c:values ( "Month" "Day" "Week" "Hour" "Minute" "Second" ) . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider referencing UNECE units of the SAMM unit catalog by referencing them via xsd:curie
https://eclipse-esmf.github.io/samm-specification/2.0.0/appendix/unitcatalog.html
eg "unit:hour"^^xsd:curie
Validation Report for io.catenax.mp_standard_request/1.0.0/ShopfloorInformationTypes.ttlValidation failed: |
Validation Report for io.catenax.mp_standard_request/1.0.0/GetProductionForecast.ttlValidation failed: |
Validation Report for io.catenax.shopfloor_information.get_production_forecast/1.0.0/GetProductionForecast.ttlValidation failed: |
@wehrstedt-jan what you could think about is to adjust the name to As all other models are describing an object as such and not an action. This comment is not hindering ms2 but might be considered in the CTSM discussion for MS3 approval If you adjust do so at the folder name, the namespace in the model file and the aspect name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments. Should be resolved prior release
|
||
:request a samm:Property ; | ||
samm:preferredName "Request"@en ; | ||
samm:description "Data model for a request"@en ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if there is a additional whitespace. If so remove.
|
||
:RequestCharacteristic a samm:Characteristic ; | ||
samm:preferredName "Request Characteristic"@en ; | ||
samm:description "DataType for a request"@en ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data type
|
||
:productionForecast4All a samm:Property ; | ||
samm:preferredName "Production forecast for all"@en ; | ||
samm:description "Boolean variable that detemines whether the customer request information about each position of an order, or information about the complete order"@en ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omit comma
samm:characteristic :TimeValueCharacteristic . | ||
|
||
:TimeValueCharacteristic a samm:Characteristic ; | ||
samm:preferredName "TimeValueCharacteristic"@en ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no camel case normal orthography
|
||
All notable changes to this model will be documented in this file. | ||
|
||
## [1.0.0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add date of mS3 approval as soon as it is available
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> . | ||
@prefix xsd: <http://www.w3.org/2001/XMLSchema#> . | ||
@prefix : <urn:samm:io.catenax.shopfloor_information.get_production_forecast:1.0.0#> . | ||
@prefix ext-header: <urn:samm:io.catenax.message_header:1.0.0#> . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it could be that this model will be moved to the namespace
io.catenax.shared.message_header:1.0.0
adjust that, if this is the case
MS2 approval given with the condition that the model io.catenax.message_header:1.0.0 is released (otherwise model cannot validate) |
MS3 Criteria All required reviewers have approved this PR (see reviewers section) -> OK |
MS3: approval given with the condition that the model io.catenax.message_header:1.0.0 is released (otherwise model cannot validate) |
Validation Report for io.catenax.shopfloor_information.get_production_forecast/1.0.0/GetProductionForecast.ttlValidation failed: |
Description
-->
Closes #229
use of header of #227 required
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)